drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-7204) Add proper validation when creating plugin
Date Fri, 17 May 2019 13:49:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842183#comment-16842183
] 

ASF GitHub Bot commented on DRILL-7204:
---------------------------------------

agozhiy commented on issue #1788: DRILL-7204: Add proper validation when creating plugin
URL: https://github.com/apache/drill/pull/1788#issuecomment-493459934
 
 
   @vvysotskyi, thank you for suggestion, did as you said.
   
   Also, added a dialog window template to use it instead of alerts.
   ![Screenshot from 2019-05-17 16-28-45](https://user-images.githubusercontent.com/31588230/57932372-70ec4900-78c3-11e9-915c-130cc0423e8a.png)
   ![Screenshot from 2019-05-17 16-28-01](https://user-images.githubusercontent.com/31588230/57932373-70ec4900-78c3-11e9-85b4-2a1f07a6cd13.png)
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add proper validation when creating plugin
> ------------------------------------------
>
>                 Key: DRILL-7204
>                 URL: https://issues.apache.org/jira/browse/DRILL-7204
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.16.0
>            Reporter: Arina Ielchiieva
>            Assignee: Anton Gozhiy
>            Priority: Major
>             Fix For: 1.17.0
>
>         Attachments: alert.JPG, new_plugin.png
>
>
> 1. Currently there is no failure when user attempts to create plugin without name. Screenshot
attached. I think we need proper plugin name validation when creating plugin.
> 2. When disabling and deleting plugin, alerts are used. Its better to use more user friendly
message window. Screenshot attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message