From issues-return-51861-archive-asf-public=cust-asf.ponee.io@drill.apache.org Fri Apr 13 20:12:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id F2052180627 for ; Fri, 13 Apr 2018 20:12:02 +0200 (CEST) Received: (qmail 56533 invoked by uid 500); 13 Apr 2018 18:12:02 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 56523 invoked by uid 99); 13 Apr 2018 18:12:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Apr 2018 18:12:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B2D05180543 for ; Fri, 13 Apr 2018 18:12:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id j7Gv-XlG-Jdq for ; Fri, 13 Apr 2018 18:12:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D73E85F178 for ; Fri, 13 Apr 2018 18:12:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 683B1E00A3 for ; Fri, 13 Apr 2018 18:12:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2C82A241C7 for ; Fri, 13 Apr 2018 18:12:00 +0000 (UTC) Date: Fri, 13 Apr 2018 18:12:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-6320) Don't Allow Javadoc comments for license headers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-6320?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1643= 7687#comment-16437687 ]=20 ASF GitHub Bot commented on DRILL-6320: --------------------------------------- Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1207#discussion_r181468772 =20 --- Diff: pom.xml --- @@ -198,6 +200,78 @@ =20 + + org.apache.rat + apache-rat-plugin + 0.12 + + --- End diff -- =20 You are right, the docs say it is bound to the validate phase by defaul= t http://creadur.apache.org/rat/apache-rat-plugin/check-mojo.html . I also = removed `validate` and tested that it work correctly. > Don't Allow Javadoc comments for license headers > ------------------------------------------------ > > Key: DRILL-6320 > URL: https://issues.apache.org/jira/browse/DRILL-6320 > Project: Apache Drill > Issue Type: Improvement > Reporter: Timothy Farkas > Assignee: Timothy Farkas > Priority: Major > Fix For: 1.14.0 > > > Currently some license headers are in a javadoc comment instead of a norm= al comment. This is not good since we don't want to include spurious licens= e headers in java docs when we publish them. The fix would be to change the= rat plugin configuration to not allow java doc comments. > =C2=A0 > *For documentation* > Min required maven version has changed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)