From issues-return-51769-archive-asf-public=cust-asf.ponee.io@drill.apache.org Wed Apr 11 01:46:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3E73518064C for ; Wed, 11 Apr 2018 01:46:03 +0200 (CEST) Received: (qmail 4696 invoked by uid 500); 10 Apr 2018 23:46:02 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 4687 invoked by uid 99); 10 Apr 2018 23:46:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Apr 2018 23:46:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id F2472C030C for ; Tue, 10 Apr 2018 23:46:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id A4t0_7lOnBl3 for ; Tue, 10 Apr 2018 23:46:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id F0A685F666 for ; Tue, 10 Apr 2018 23:46:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7E4ACE0B65 for ; Tue, 10 Apr 2018 23:46:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1576E21209 for ; Tue, 10 Apr 2018 23:46:00 +0000 (UTC) Date: Tue, 10 Apr 2018 23:46:00 +0000 (UTC) From: "Timothy Farkas (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-6320) Don't Allow Javadoc comments for license headers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-6320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433189#comment-16433189 ] Timothy Farkas commented on DRILL-6320: --------------------------------------- This is getting involved. I need to replace apache rat with the com.mycila license-maven-plugin in order to be able to do this. The good news is that license-maven-plugin is multi-threaded and way faster than rat > Don't Allow Javadoc comments for license headers > ------------------------------------------------ > > Key: DRILL-6320 > URL: https://issues.apache.org/jira/browse/DRILL-6320 > Project: Apache Drill > Issue Type: Improvement > Reporter: Timothy Farkas > Assignee: Timothy Farkas > Priority: Major > > Currently some license headers are in a javadoc comment instead of a normal comment. This is not good since we don't want to include spurious license headers in java docs when we publish them. The fix would be to change the rat plugin configuration to not allow java doc comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005)