drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6289) Cluster view should show more relevant information
Date Fri, 13 Apr 2018 21:11:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437919#comment-16437919
] 

ASF GitHub Bot commented on DRILL-6289:
---------------------------------------

Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1203#discussion_r181510944
  
    --- Diff: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java ---
    @@ -0,0 +1,62 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.metrics;
    +
    +import java.lang.management.OperatingSystemMXBean;
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +import com.codahale.metrics.Gauge;
    +import com.codahale.metrics.Metric;
    +import com.codahale.metrics.MetricSet;
    +
    +/**
    + * Creates a Cpu GaugeSet
    + */
    +class CpuGaugeSet implements MetricSet {
    --- End diff --
    
    I thought we might want to expand the GaugeSet to carry additional metrics like `ProcessCpuLoad`
and `ProcessCpuTime` . 
    Since we can shrink the {{SHUTDOWN}} button to a symbol, we do have some real-estate to
provide the ProcessCPULoad information as well. Would it help to have that? 
    https://docs.oracle.com/javase/7/docs/jre/api/management/extension/com/sun/management/OperatingSystemMXBean.html#getProcessCpuLoad()



> Cluster view should show more relevant information
> --------------------------------------------------
>
>                 Key: DRILL-6289
>                 URL: https://issues.apache.org/jira/browse/DRILL-6289
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>    Affects Versions: 1.13.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>            Priority: Major
>             Fix For: 1.14.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> When fixing DRILL-6224, I noticed that the same information can be very useful to have
in the cluster view shown on a Drillbit's homepage. 
> The proposal is to show the following:
> # Heap Memory in use
> # Direct Memory (actively) in use - Since we're not able to get the total memory held
by Netty at the moment, but only what is currently allocated to running queries
> # Process CPU
> # Average (System) Load Factor 
> Information such as the port numbers don't help much during general cluster health, so
it might be worth removing this information if more real-estate is needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message