drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6289) Cluster view should show more relevant information
Date Fri, 13 Apr 2018 00:33:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436562#comment-16436562
] 

ASF GitHub Bot commented on DRILL-6289:
---------------------------------------

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1203#discussion_r181252867
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
---
    @@ -158,7 +158,13 @@ public void start() throws Exception {
         final int selectors = config.getInt(ExecConstants.HTTP_JETTY_SERVER_SELECTORS);
         final QueuedThreadPool threadPool = new QueuedThreadPool(2, 2, 60000);
         embeddedJetty = new Server(threadPool);
    -    embeddedJetty.setHandler(createServletContextHandler(authEnabled));
    +    ServletContextHandler webServerContext = createServletContextHandler(authEnabled);
    +    //Allow for Other Drillbits to make REST calls
    +    FilterHolder filterHolder = new FilterHolder(CrossOriginFilter.class);
    +    filterHolder.setInitParameter("allowedOrigins", "*");
    --- End diff --
    
    I am not too familiar with CORS concept but would be good to see if we can be more restrictive
instead of just *. Also when authentication is enabled then with this filter, CORS request
still requires authentication right ? Can you please confirm this?


> Cluster view should show more relevant information
> --------------------------------------------------
>
>                 Key: DRILL-6289
>                 URL: https://issues.apache.org/jira/browse/DRILL-6289
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>    Affects Versions: 1.13.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>            Priority: Major
>             Fix For: 1.14.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> When fixing DRILL-6224, I noticed that the same information can be very useful to have
in the cluster view shown on a Drillbit's homepage. 
> The proposal is to show the following:
> # Heap Memory in use
> # Direct Memory (actively) in use - Since we're not able to get the total memory held
by Netty at the moment, but only what is currently allocated to running queries
> # Process CPU
> # Average (System) Load Factor 
> Information such as the port numbers don't help much during general cluster health, so
it might be worth removing this information if more real-estate is needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message