drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6230) Extend row set readers to handle hyper vectors
Date Sun, 01 Apr 2018 01:05:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421543#comment-16421543
] 

ASF GitHub Bot commented on DRILL-6230:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1161#discussion_r177833383
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/model/ReaderIndex.java
---
    @@ -28,26 +28,30 @@
     
     public abstract class ReaderIndex implements ColumnReaderIndex {
     
    -  protected int rowIndex = -1;
    +  protected int position = -1;
       protected final int rowCount;
     
       public ReaderIndex(int rowCount) {
         this.rowCount = rowCount;
       }
     
    -  public int position() { return rowIndex; }
    -  public void set(int index) { rowIndex = index; }
    +  public void set(int index) {
    +    assert position >= -1 && position <= rowCount;
    +    position = index;
    +  }
    +
    +  @Override
    +  public int logicalIndex() { return position; }
    +
    +  @Override
    +  public int size() { return rowCount; }
     
    +  @Override
       public boolean next() {
    -    if (++rowIndex < rowCount ) {
    +    if (++position < rowCount) {
           return true;
    -    } else {
    -      rowIndex--;
    -      return false;
         }
    +    position = rowCount;
    --- End diff --
    
    Not entirely necessary. This is more for safety to force the position to a known good
value. But, I can remove it if desired.


> Extend row set readers to handle hyper vectors
> ----------------------------------------------
>
>                 Key: DRILL-6230
>                 URL: https://issues.apache.org/jira/browse/DRILL-6230
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Major
>             Fix For: 1.14.0
>
>
> The current row set readers have incomplete support for hyper-vectors. To add full support,
we need an interface that supports either single batches or hyper batches. Accessing vectors
in hyper batches differs depending on whether the vector is at the top level or is nested.
SeeĀ [this post|https://github.com/paul-rogers/drill/wiki/BH-Column-Readers] for details.
Also includes a simpler reader template: replaces the original three classes with one, in
parallel with the writers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message