From issues-return-51369-archive-asf-public=cust-asf.ponee.io@drill.apache.org Wed Mar 28 03:31:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 756AF180787 for ; Wed, 28 Mar 2018 03:31:05 +0200 (CEST) Received: (qmail 83252 invoked by uid 500); 28 Mar 2018 01:31:04 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 82795 invoked by uid 99); 28 Mar 2018 01:31:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Mar 2018 01:31:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C6F29C04EE for ; Wed, 28 Mar 2018 01:31:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Wdo_X0LtS_Q9 for ; Wed, 28 Mar 2018 01:31:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B012360DFE for ; Wed, 28 Mar 2018 01:31:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E4E86E0DE7 for ; Wed, 28 Mar 2018 01:31:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D05262151B for ; Wed, 28 Mar 2018 01:31:00 +0000 (UTC) Date: Wed, 28 Mar 2018 01:31:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-6284) Add operator metrics for batch sizing for flatten MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-6284?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1641= 6568#comment-16416568 ]=20 ASF GitHub Bot commented on DRILL-6284: --------------------------------------- Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r177617387 =20 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/i= mpl/flatten/FlattenRecordBatch.java --- @@ -463,4 +488,20 @@ protected boolean setupNewSchema() throws SchemaCh= angeException { } return exprs; } + + private void updateStats() { + stats.setLongStat(Metric.NUM_INCOMING_BATCHES, flattenMemoryManage= r.getNumIncomingBatches()); + stats.setLongStat(Metric.AVG_INPUT_BATCH_SIZE, flattenMemoryManage= r.getAvgInputBatchSize()); + stats.setLongStat(Metric.AVG_INPUT_ROW_WIDTH, flattenMemoryManager= .getAvgInputRowWidth()); + stats.setLongStat(Metric.TOTAL_INPUT_RECORDS, flattenMemoryManager= .getTotalInputRecords()); + stats.setLongStat(Metric.NUM_OUTGOING_BATCHES, flattenMemoryManage= r.getNumOutgoingBatches()); + stats.setLongStat(Metric.AVG_OUTPUT_BATCH_SIZE, flattenMemoryManag= er.getAvgOutputBatchSize()); + stats.setLongStat(Metric.AVG_OUTPUT_ROW_WIDTH, flattenMemoryManage= r.getAvgOutputRowWidth()); + stats.setLongStat(Metric.TOTAL_OUTPUT_RECORDS, flattenMemoryManage= r.getTotalOutputRecords()); + } + + @Override + public void close() { --- End diff -- =20 Is `super.close()` needed? > Add operator metrics for batch sizing for flatten > ------------------------------------------------- > > Key: DRILL-6284 > URL: https://issues.apache.org/jira/browse/DRILL-6284 > Project: Apache Drill > Issue Type: Improvement > Components: Execution - Flow > Affects Versions: 1.13.0 > Reporter: Padma Penumarthy > Assignee: Padma Penumarthy > Priority: Critical > Fix For: 1.14.0 > > > Add the following operator metrics for flatten. > NUM_INCOMING_BATCHES, > AVG_INPUT_BATCH_SIZE, > AVG_INPUT_ROW_WIDTH, > TOTAL_INPUT_RECORDS, > NUM_OUTGOING_BATCHES, > AVG_OUTPUT_BATCH_SIZE, > AVG_OUTPUT_ROW_WIDTH, > TOTAL_OUTPUT_RECORDS; > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)