From issues-return-50823-archive-asf-public=cust-asf.ponee.io@drill.apache.org Wed Mar 14 13:10:08 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BF17A18077F for ; Wed, 14 Mar 2018 13:10:07 +0100 (CET) Received: (qmail 76580 invoked by uid 500); 14 Mar 2018 12:10:06 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 76571 invoked by uid 99); 14 Mar 2018 12:10:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Mar 2018 12:10:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6CA911821A4 for ; Wed, 14 Mar 2018 12:10:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 40LpSq6za3x6 for ; Wed, 14 Mar 2018 12:10:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E4D2D5F178 for ; Wed, 14 Mar 2018 12:10:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0C4A8E0CF7 for ; Wed, 14 Mar 2018 12:10:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 69BD22149A for ; Wed, 14 Mar 2018 12:10:00 +0000 (UTC) Date: Wed, 14 Mar 2018 12:10:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-6053) Avoid excessive locking in LocalPersistentStore MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398472#comment-16398472 ] ASF GitHub Bot commented on DRILL-6053: --------------------------------------- Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1163#discussion_r174433799 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/PersistentStoreProvider.java --- @@ -33,7 +34,9 @@ * @param store value type */ PersistentStore getOrCreateStore(PersistentStoreConfig config) throws StoreException; - + default VersionedPersistentStore getOrCreateVersionedStore(PersistentStoreConfig config) throws StoreException { --- End diff -- Please add javadoc here and in newly created classes as well. > Avoid excessive locking in LocalPersistentStore > ----------------------------------------------- > > Key: DRILL-6053 > URL: https://issues.apache.org/jira/browse/DRILL-6053 > Project: Apache Drill > Issue Type: Improvement > Reporter: Vlad Rozov > Assignee: Vlad Rozov > Priority: Major > Fix For: 1.14.0 > > > When query profiles are written to LocalPersistentStore, the write is unnecessary serialized due to read/write lock that was introduced for versioned PersistentStore. Only versioned access needs to be protected by read/write lock. -- This message was sent by Atlassian JIRA (v7.6.3#76005)