drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6294) Update Calcite version to 1.16.0
Date Fri, 30 Mar 2018 20:29:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420906#comment-16420906
] 

ASF GitHub Bot commented on DRILL-6294:
---------------------------------------

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1198#discussion_r178371341
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java
---
    @@ -218,7 +218,8 @@ private void reduceAggs(
             RelOptUtil.createProject(
                 newAggRel,
                 projList,
    -            oldAggRel.getRowType().getFieldNames());
    +            oldAggRel.getRowType().getFieldNames(),
    +            DrillRelFactories.LOGICAL_BUILDER);
    --- End diff --
    
    In the second commit it was fixed and used relBuilderFactory to create builder and project.



> Update Calcite version to 1.16.0
> --------------------------------
>
>                 Key: DRILL-6294
>                 URL: https://issues.apache.org/jira/browse/DRILL-6294
>             Project: Apache Drill
>          Issue Type: Task
>    Affects Versions: 1.13.0
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>             Fix For: 1.14.0
>
>
> Upgrade to Calcite 16 version.
>  From the last upgrade to Calcite 15, several commits were left in Drill-Calcite fork.
Since no additional work was done to move those commits from the fork, they will be placed
on top of Calcite 16.
>  Status from the last upgrade:
>  [https://docs.google.com/document/d/1Lqk9NoKQviz0YimBmov4z1pui7QjJGjDVwMa1p0emPk/edit#heading=h.i3rowg20vxv4]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message