drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6284) Add operator metrics for batch sizing for flatten
Date Wed, 28 Mar 2018 01:31:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416568#comment-16416568
] 

ASF GitHub Bot commented on DRILL-6284:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1181#discussion_r177617387
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
    @@ -463,4 +488,20 @@ protected boolean setupNewSchema() throws SchemaChangeException {
         }
         return exprs;
       }
    +
    +  private void updateStats() {
    +    stats.setLongStat(Metric.NUM_INCOMING_BATCHES, flattenMemoryManager.getNumIncomingBatches());
    +    stats.setLongStat(Metric.AVG_INPUT_BATCH_SIZE, flattenMemoryManager.getAvgInputBatchSize());
    +    stats.setLongStat(Metric.AVG_INPUT_ROW_WIDTH, flattenMemoryManager.getAvgInputRowWidth());
    +    stats.setLongStat(Metric.TOTAL_INPUT_RECORDS, flattenMemoryManager.getTotalInputRecords());
    +    stats.setLongStat(Metric.NUM_OUTGOING_BATCHES, flattenMemoryManager.getNumOutgoingBatches());
    +    stats.setLongStat(Metric.AVG_OUTPUT_BATCH_SIZE, flattenMemoryManager.getAvgOutputBatchSize());
    +    stats.setLongStat(Metric.AVG_OUTPUT_ROW_WIDTH, flattenMemoryManager.getAvgOutputRowWidth());
    +    stats.setLongStat(Metric.TOTAL_OUTPUT_RECORDS, flattenMemoryManager.getTotalOutputRecords());
    +  }
    +
    +  @Override
    +  public void close() {
    --- End diff --
    
    Is `super.close()` needed?


> Add operator metrics for batch sizing for flatten
> -------------------------------------------------
>
>                 Key: DRILL-6284
>                 URL: https://issues.apache.org/jira/browse/DRILL-6284
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Flow
>    Affects Versions: 1.13.0
>            Reporter: Padma Penumarthy
>            Assignee: Padma Penumarthy
>            Priority: Critical
>             Fix For: 1.14.0
>
>
> Add the following operator metrics for flatten.
> NUM_INCOMING_BATCHES,
> AVG_INPUT_BATCH_SIZE,
> AVG_INPUT_ROW_WIDTH,
> TOTAL_INPUT_RECORDS,
> NUM_OUTGOING_BATCHES,
> AVG_OUTPUT_BATCH_SIZE,
> AVG_OUTPUT_ROW_WIDTH,
> TOTAL_OUTPUT_RECORDS;
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message