drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6280) Cleanup execution of BuildTimeScan during maven build
Date Wed, 21 Mar 2018 22:33:01 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408690#comment-16408690
] 

ASF GitHub Bot commented on DRILL-6280:
---------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1177#discussion_r176260351
  
    --- Diff: exec/java-exec/pom.xml ---
    @@ -828,31 +828,9 @@
               </execution>
             </executions>
           </plugin>
    -      <plugin> <!-- classpath scanning  -->
    +      <plugin>
             <groupId>org.codehaus.mojo</groupId>
             <artifactId>exec-maven-plugin</artifactId>
    -        <version>1.2.1</version>
    -        <dependencies>
    -          <dependency>
    -            <groupId>org.apache.drill</groupId>
    -            <artifactId>drill-common</artifactId>
    -            <version>${project.version}</version>
    -            <classifier>tests</classifier>
    -          </dependency>
    -        </dependencies>
    -        <executions>
    -          <execution>
    -            <phase>process-classes</phase>
    -            <goals><goal>java</goal></goals>
    -          </execution>
    -        </executions>
    -        <configuration>
    -          <mainClass>org.apache.drill.common.scanner.BuildTimeScan</mainClass>
    -          <includePluginDependencies>true</includePluginDependencies>
    --- End diff --
    
    The plugin is now configured in the `PluginManagement` section in the drill root pom.


> Cleanup execution of BuildTimeScan during maven build
> -----------------------------------------------------
>
>                 Key: DRILL-6280
>                 URL: https://issues.apache.org/jira/browse/DRILL-6280
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Vlad Rozov
>            Assignee: Vlad Rozov
>            Priority: Minor
>
> {{exec:java}} has a dependency on {{logback-classic}} that is only available in {{test}}
scope.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message