drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6278) DRILL-5993 Made Debugging Generated Code Harder
Date Sun, 25 Mar 2018 11:03:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412982#comment-16412982

ASF GitHub Bot commented on DRILL-6278:

Github user vvysotskyi commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TopN/TopNBatchTest.java
    @@ -159,7 +157,6 @@ public void priorityQueueOrderingTest() throws Exception {
       public void sortOneKeyAscending() throws Throwable {
         ClusterFixtureBuilder builder = ClusterFixture.builder(dirTestWatcher)
    -      .configProperty(ClassBuilder.CODE_DIR_OPTION, dirTestWatcher.getDir().getAbsolutePath())
           .configProperty(CodeCompiler.ENABLE_SAVE_CODE_FOR_DEBUG_TOPN, true);
    --- End diff --
    I think this line should be also removed since `ENABLE_SAVE_CODE_FOR_DEBUG_TOPN` should
be disabled for tests.

> DRILL-5993 Made Debugging Generated Code Harder
> -----------------------------------------------
>                 Key: DRILL-6278
>                 URL: https://issues.apache.org/jira/browse/DRILL-6278
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>            Priority: Major
> DRILL-5993 made debugging generated code more difficult since it stored generated code
in unique directories in target. This required adding possibly many tmp directories as source
folders in order to be able to set break points in generated code for different tests. This
change should be reverted to store generated code in the original default /tmp/drill/codegen

This message was sent by Atlassian JIRA

View raw message