drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6246) Build Failing in jdbc-all artifact
Date Fri, 16 Mar 2018 10:41:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401723#comment-16401723

ASF GitHub Bot commented on DRILL-6246:

Github user vvysotskyi commented on the issue:

    Classes from `avatica.metrics` are used in `JsonHandler`, `ProtobufHandler` and `LocalService`.
If Drill does not use these classes than I agree that we can exclude it from `jdbc-all` jar.

    Regarding excluding `avatica/org/**`, looks like the problem is in the Avatica pom files
since there are no dependencies to `org.apache.commons` and `org.apache.http`, but they are
shaded to the jar. Created Jira CALCITE-2215 to fix this issue, but for now, I think it's
ok to exclude them.

> Build Failing in jdbc-all artifact
> ----------------------------------
>                 Key: DRILL-6246
>                 URL: https://issues.apache.org/jira/browse/DRILL-6246
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - JDBC
>    Affects Versions: 1.13.0
>            Reporter: salim achouche
>            Assignee: salim achouche
>            Priority: Major
> * {color:#000000}It was noticed that the build was failing because of the jdbc-all artifact{color}
>  * {color:#000000}The maximum compressed jar size was set to 32MB but we are currently
creating a JAR a bit larger than 32MB {color}
>  * {color:#000000}I compared apache drill-1.10.0, drill-1.12.0, and drill-1.13.0 (on
my MacOS){color}
>  * {color:#000000}jdbc-all-1.10.0 jar size: 21MB{color}
>  * {color:#000000}jdbc-all-1.12.0 jar size: 27MB{color}
>  * {color:#000000}jdbc-all-1.13.0 jar size: 34MB (on Linux this size is roughly 32MB){color}
>  * {color:#000000}Compared then in more details jdbc-all-1.12.0 and jdbc-all-1.13.0{color}
>  * {color:#000000}The bulk of the increase is attributed to the calcite artifact{color}
>  * {color:#000000}Used to be 2MB (uncompressed) and now 22MB (uncompressed){color}
>  * {color:#000000}It is likely an exclusion problem {color}
>  * {color:#000000}The jdbc-all-1.12.0 version has only two top packages calcite/avatica/utils
and calcite/avatica/remote{color}
>  * {color:#000000}The jdbc-all-1.13.0  includes new packages (within calcite/avatica)
metrics, proto, org/apache/, com/fasterxml, com/google{color}
> {color:#000000} {color}
> {color:#000000}I am planning to exclude these new sub-packages{color}

This message was sent by Atlassian JIRA

View raw message