drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6210) Enhance the test schema builder for remaining types
Date Mon, 05 Mar 2018 00:17:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385444#comment-16385444
] 

ASF GitHub Bot commented on DRILL-6210:
---------------------------------------

GitHub user paul-rogers opened a pull request:

    https://github.com/apache/drill/pull/1150

    DRILL-6210: Enhanced test schema utilities

    The result set loader project enhanced the schema builder used in tests to handle Drill's
complex types: maps, unions, lists and repeated lists. The schema builder previously only
handled maps.
    This PR describes the addition of just this one part of the result set loader.
    
    Also adds a run-time schema improvement: functions to create arrays when testing. Old
style:
    
    ```
      rowSetBuilder.addRow(1,  new String[] {"foo", "bar"});
    ```
    
    New style:
    ```
      rowSetBuilder.addRow(1,  strArray"foo", "bar"));
    ```


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-rogers/drill DRILL-6210

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1150
    
----
commit abae5200a86b3b68bb1f8e2bb85768a1b814df58
Author: Paul Rogers <progers@...>
Date:   2018-03-05T00:14:33Z

    DRILL-6210: Enhanced test schema utilities

----


> Enhance the test schema builder for remaining types
> ---------------------------------------------------
>
>                 Key: DRILL-6210
>                 URL: https://issues.apache.org/jira/browse/DRILL-6210
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Major
>             Fix For: 1.14.0
>
>
> The result set loader project enhanced the schema builder used in tests to handle Drill's
complex types: maps, unions, lists and repeated lists. The schema builder previously only
handled maps.
> This ticket describes the addition of just this one part of the result set loader.
> Also adds a run-time schema improvement: functions to create arrays when testing rather
than writing out the {{new String[] \{"foo", "bar"\}}} syntax.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message