drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kunal Khatua (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6183) Default value for parameter 'planner.width.max_per_node'
Date Thu, 08 Mar 2018 02:17:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390600#comment-16390600
] 

Kunal Khatua commented on DRILL-6183:
-------------------------------------

[~arjun_kr], there was a change introduced in 1.12 (DRILL-5547) that takes into account CPU
load factor, which is the 70% you are referring to.
https://github.com/apache/drill/blame/master/exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java#L262

The reason for this is that Zero is indicative of the maxWidth being done during planning
time and need not be specified upfront. The original code would use the hard-coded 70%. 

A possible workaround could be to have the default pre-computed from the provided default
cpu_load_factor so that you know what the default would be.

> Default value for parameter 'planner.width.max_per_node'
> --------------------------------------------------------
>
>                 Key: DRILL-6183
>                 URL: https://issues.apache.org/jira/browse/DRILL-6183
>             Project: Apache Drill
>          Issue Type: Bug
>          Components:  Server
>    Affects Versions: 1.12.0
>         Environment: Drill 1.12
>            Reporter: Arjun
>            Assignee: Kunal Khatua
>            Priority: Minor
>
> The default value for configuration parameter 'planner.width.max_per_node' is shown as
0 in Drill 1.12. In the previous versions, the default value is set as 70% total core in
the drillbit node.This could be confusing for users upgrading from previous versions ( Whether
it is unlimited value).  
> {code:java}
> 0: jdbc:drill:drillbit=localhost> select * from sys.options where name like '%planner.width%';

> +------------------------------+-------+-------------------+--------------+----------+----------+-------------+-----------+------------+
> | name | kind | accessibleScopes | optionScope | status | num_val | string_val | bool_val
| float_val |
> +------------------------------+-------+-------------------+--------------+----------+----------+-------------+-----------+------------+
> | planner.width.max_per_node | LONG | ALL | BOOT | DEFAULT | 0 | null | null | null |
> | planner.width.max_per_query | LONG | ALL | BOOT | DEFAULT | 1000 | null | null | null
|
> +------------------------------+-------+-------------------+--------------+----------+----------+-------------+-----------+------------+
> 2 rows selected (0.913 seconds) 0: jdbc:drill:drillbit=localhost>
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message