drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6053) Avoid excessive locking in LocalPersistentStore
Date Wed, 14 Mar 2018 17:49:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398981#comment-16398981
] 

ASF GitHub Bot commented on DRILL-6053:
---------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1163#discussion_r174551433
  
    --- Diff: common/src/main/java/org/apache/drill/common/AutoCloseables.java ---
    @@ -25,6 +25,11 @@
      */
     public class AutoCloseables {
     
    +  public interface Closeable extends AutoCloseable {
    --- End diff --
    
    It is on purpose:
    - There is a minimal difference between Drill `Closeable` and Java 'Closeable/AutoCloseable`,
so name reflects that.
    - It won't be possible to use Drill `Closeable` in place of Java `Closeable/AutoCloseable`
in case `close()` throws checked exception.
    - Drill `Closeable` is not a top level interface, so where it is necessary to distinguish
Drill `Closeable` from Java `Closeable` full name `AutoClosables.Closeable` should be used.


> Avoid excessive locking in LocalPersistentStore
> -----------------------------------------------
>
>                 Key: DRILL-6053
>                 URL: https://issues.apache.org/jira/browse/DRILL-6053
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Vlad Rozov
>            Assignee: Vlad Rozov
>            Priority: Major
>             Fix For: 1.14.0
>
>
> When query profiles are written to LocalPersistentStore, the write is unnecessary serialized
due to read/write lock that was introduced for versioned PersistentStore. Only versioned access
needs to be protected by read/write lock.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message