drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6053) Avoid excessive locking in LocalPersistentStore
Date Wed, 14 Mar 2018 12:10:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398472#comment-16398472
] 

ASF GitHub Bot commented on DRILL-6053:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1163#discussion_r174433799
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/PersistentStoreProvider.java
---
    @@ -33,7 +34,9 @@
        * @param <V>  store value type
        */
       <V> PersistentStore<V> getOrCreateStore(PersistentStoreConfig<V>
config) throws StoreException;
    -
    +  default <V> VersionedPersistentStore<V> getOrCreateVersionedStore(PersistentStoreConfig<V>
config) throws StoreException {
    --- End diff --
    
    Please add javadoc here and in newly created classes as well.


> Avoid excessive locking in LocalPersistentStore
> -----------------------------------------------
>
>                 Key: DRILL-6053
>                 URL: https://issues.apache.org/jira/browse/DRILL-6053
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Vlad Rozov
>            Assignee: Vlad Rozov
>            Priority: Major
>             Fix For: 1.14.0
>
>
> When query profiles are written to LocalPersistentStore, the write is unnecessary serialized
due to read/write lock that was introduced for versioned PersistentStore. Only versioned access
needs to be protected by read/write lock.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message