drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6053) Avoid excessive locking in LocalPersistentStore
Date Wed, 14 Mar 2018 12:10:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398467#comment-16398467
] 

ASF GitHub Bot commented on DRILL-6053:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1163#discussion_r174431507
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/VersionedPersistentStore.java
---
    @@ -0,0 +1,54 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.drill.exec.store.sys;
    +
    +import org.apache.drill.exec.store.sys.store.DataChangeVersion;
    +
    +public interface VersionedPersistentStore<V> extends Store<V>
    +{
    --- End diff --
    
    Please move to upper line.


> Avoid excessive locking in LocalPersistentStore
> -----------------------------------------------
>
>                 Key: DRILL-6053
>                 URL: https://issues.apache.org/jira/browse/DRILL-6053
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Vlad Rozov
>            Assignee: Vlad Rozov
>            Priority: Major
>             Fix For: 1.14.0
>
>
> When query profiles are written to LocalPersistentStore, the write is unnecessary serialized
due to read/write lock that was introduced for versioned PersistentStore. Only versioned access
needs to be protected by read/write lock.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message