drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6044) Shutdown button does not work from WebUI
Date Thu, 08 Mar 2018 00:43:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390518#comment-16390518
] 

ASF GitHub Bot commented on DRILL-6044:
---------------------------------------

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1153#discussion_r173031821
  
    --- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
    @@ -247,11 +253,14 @@
                     $("#row-"+i).find("#queriesCount").text("");
                 }
                 else {
    -                if( status_map[key] == "ONLINE") {
    +                if (status_map[key] == "ONLINE") {
                         $("#row-"+i).find("#status").text(status_map[key]);
                     }
                     else {
    -                    fillQueryCount(address,i);
    +                    var is_ssl_enabled = $('#ssl').val();
    +                    if (is_ssl_enabled != "ssl_enabled") {
    +                        fillQueryCount(address,i);
    --- End diff --
    
    `fillQueryCount` should also handle the case for Https and Http just like `shutdown`.
Looks like currently with this change if SSL is enabled then we won't be able to get the queryCount
of Drillbit shutting down.
    Why not handle it in same way as for `shutdown` method ?


> Shutdown button does not work from WebUI
> ----------------------------------------
>
>                 Key: DRILL-6044
>                 URL: https://issues.apache.org/jira/browse/DRILL-6044
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - HTTP
>    Affects Versions: 1.13.0
>            Reporter: Krystal
>            Assignee: Venkata Jyothsna Donapati
>            Priority: Critical
>             Fix For: 1.13.0
>
>         Attachments: Screen Shot 2017-12-19 at 10.51.16 AM.png
>
>
> git.commit.id.abbrev=eb0c403
> Nothing happens when click on the SHUTDOWN button from the WebUI.  The browser's debugger
showed that the request failed due to access control checks (see attached screen shot).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message