drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5937) prepare.statement.create_timeout_ms default is 10 seconds but code comment says default should be 10 mins
Date Mon, 26 Mar 2018 14:18:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413907#comment-16413907
] 

ASF GitHub Bot commented on DRILL-5937:
---------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1190#discussion_r177103076
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -558,7 +558,7 @@ private ExecConstants() {
     
       /**
        * Timeout for create prepare statement request. If the request exceeds this timeout,
then request is timed out.
    -   * Default value is 10mins.
    +   * Default value is 30 seconds.
    --- End diff --
    
    Is it 30 seconds or 10 seconds? In any case, I don't think that the entire comment provides
any additional info that cannot be inferred from the code itself.


>  prepare.statement.create_timeout_ms default is 10 seconds but code comment says default
should be 10 mins
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-5937
>                 URL: https://issues.apache.org/jira/browse/DRILL-5937
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning &amp; Optimization
>    Affects Versions: 1.8.0
>            Reporter: Pushpendra Jaiswal
>            Priority: Major
>             Fix For: 1.14.0
>
>
> prepare.statement.create_timeout_ms default is 10 seconds but code comment says default
should be 10 mins
> The value is by default set to 10000 ms 
> https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java#L526

> /**
>    * Timeout for create prepare statement request. If the request exceeds this timeout,
then request is timed out.
>    * Default value is 10mins.
>    */



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message