drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pritesh Maker (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DRILL-5829) RecordBatchLoader schema comparison is not case insensitive
Date Tue, 06 Mar 2018 17:15:00 GMT

     [ https://issues.apache.org/jira/browse/DRILL-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Pritesh Maker updated DRILL-5829:
---------------------------------
    Fix Version/s:     (was: 1.13.0)
                   1.14.0

> RecordBatchLoader schema comparison is not case insensitive
> -----------------------------------------------------------
>
>                 Key: DRILL-5829
>                 URL: https://issues.apache.org/jira/browse/DRILL-5829
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.11.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Major
>             Fix For: 1.14.0
>
>
> The class {{RecordBatchLoader}} decodes batches received over the wire. It determines
if the schema of the new batch matches that of the old one. To do that, it uses a map of existing
columns.
> In Drill, column names follow SQL rules: they are case insensitive. Yet, the implementation
of {{RecordBatchLoader}} uses a case sensitive map:
> {code}
>     final Map<String, ValueVector> oldFields = Maps.newHashMap();
> {code}
> This should be:
> {code}
>     final Map<String, ValueVector> oldFields = CaseInsensitiveMap.newHashMap();
> {code}
> Without this change, the receivers will report schema changes if a column differs only
in name case. However, Drill semantics say that names that differ in case are identical, and
so no schema change should be issued.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message