drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4120) dir0 does not work when the directory structure contains Avro files
Date Tue, 06 Mar 2018 19:32:01 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388385#comment-16388385
] 

ASF GitHub Bot commented on DRILL-4120:
---------------------------------------

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1138#discussion_r172630422
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
    @@ -277,6 +279,25 @@ public String deriveAlias(
           return SqlValidatorUtil.getAlias(node, ordinal);
         }
     
    +    /**
    +     * Checks that specified expression is not implicit column and
    +     * adds is to a select list, ensuring that its alias does not
    +     * clash with any existing expressions on the list.
    +     */
    +    @Override
    +    protected void addToSelectList(
    --- End diff --
    
    Added comment into Javadoc, which describes when and why this method is used.
    
    As for Avro and Dynamic tables, the key point is the result of `RelDataType.isDynamicStruct()`
method. 
    For `AvroDrillTable` we use `ExtendableRelDataType` whose `isDynamicStruct()` method returns
`false`, but for `DynamicDrillTable` we use `RelDataTypeDrillImpl`  whose `isDynamicStruct()`
method returns `true`. 
    In such way, Calcites `SqlValidatorImpl` determines whether columns should be added.


> dir0 does not work when the directory structure contains Avro files
> -------------------------------------------------------------------
>
>                 Key: DRILL-4120
>                 URL: https://issues.apache.org/jira/browse/DRILL-4120
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning &amp; Optimization
>    Affects Versions: 1.3.0
>            Reporter: Stefán Baxter
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>             Fix For: 1.13.0
>
>         Attachments: 0001-DRILL-4120-Support-reading-directories-having-avro-f.patch
>
>
> Any select statment containing dirN fails if the target directory structure contains
Avro files.
> Steps to test:
> 1. create a simple directory structure
> 2. copy an avro file into each directory
> 3. execute a query containing dir0
> outcome:
> Error: VALIDATION ERROR: From line 1, column 117 to line 1, column 120: Column 'dir0'
not found in any table



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message