From issues-return-50035-archive-asf-public=cust-asf.ponee.io@drill.apache.org Tue Feb 27 13:24:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0BA05180671 for ; Tue, 27 Feb 2018 13:24:04 +0100 (CET) Received: (qmail 50426 invoked by uid 500); 27 Feb 2018 12:24:04 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 50414 invoked by uid 99); 27 Feb 2018 12:24:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Feb 2018 12:24:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 689111A02F9 for ; Tue, 27 Feb 2018 12:24:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -102.311 X-Spam-Level: X-Spam-Status: No, score=-102.311 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id yQG0cNXy1_6t for ; Tue, 27 Feb 2018 12:24:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 8B0B45F520 for ; Tue, 27 Feb 2018 12:24:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AA64BE0248 for ; Tue, 27 Feb 2018 12:24:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3BEC124088 for ; Tue, 27 Feb 2018 12:24:00 +0000 (UTC) Date: Tue, 27 Feb 2018 12:24:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-6174) Parquet pushdown planning improvements MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-6174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378492#comment-16378492 ] ASF GitHub Bot commented on DRILL-6174: --------------------------------------- Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1131#discussion_r170902502 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetBooleanPredicates.java --- @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.expr.stat; + +import org.apache.drill.common.expression.BooleanOperator; +import org.apache.drill.common.expression.ExpressionPosition; +import org.apache.drill.common.expression.LogicalExpression; +import org.apache.drill.common.expression.visitors.ExprVisitor; + +import java.util.List; + +public abstract class ParquetBooleanPredicates { --- End diff -- 1. Please remove abstract. 2. Add javadoc. Here and in other two similar classes. > Parquet pushdown planning improvements > -------------------------------------- > > Key: DRILL-6174 > URL: https://issues.apache.org/jira/browse/DRILL-6174 > Project: Apache Drill > Issue Type: Improvement > Affects Versions: 1.12.0 > Reporter: Arina Ielchiieva > Assignee: Roman Kulyk > Priority: Major > Labels: doc-impacting > Fix For: 1.13.0 > > > Currently parquet pushdown planning has certain limitations (https://drill.apache.org/docs/parquet-filter-pushdown/). This Jira aims to fix some of them. List of improvements can be find below: > 1. IS [NOT] NULL / TRUE / FALSE > 2. Timestamp / date / time implicit / explicit casts > {noformat} > timestamp -> date > timestamp -> varchar > date -> timestamp > date -> varchar > time -> timestamp > time -> date > time -> varchar > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)