From issues-return-49876-archive-asf-public=cust-asf.ponee.io@drill.apache.org Tue Feb 20 05:05:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D9C26180607 for ; Tue, 20 Feb 2018 05:05:06 +0100 (CET) Received: (qmail 62144 invoked by uid 500); 20 Feb 2018 04:05:06 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 62135 invoked by uid 99); 20 Feb 2018 04:05:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Feb 2018 04:05:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 8A553C0160 for ; Tue, 20 Feb 2018 04:05:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_FILL_THIS_FORM_SHORT=0.01, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id xTJyA9FK4M40 for ; Tue, 20 Feb 2018 04:05:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 163515F341 for ; Tue, 20 Feb 2018 04:05:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id F1F87E031B for ; Tue, 20 Feb 2018 04:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 533932255B for ; Tue, 20 Feb 2018 04:05:00 +0000 (UTC) Date: Tue, 20 Feb 2018 04:05:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-6153) Revised operator framework MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-6153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369698#comment-16369698 ] ASF GitHub Bot commented on DRILL-6153: --------------------------------------- Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1121#discussion_r169203509 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/protocol/OperatorDriver.java --- @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.physical.impl.protocol; + +import org.apache.drill.common.exceptions.UserException; +import org.apache.drill.exec.ops.OperatorContext; +import org.apache.drill.exec.record.RecordBatch.IterOutcome; + +/** + * State machine that drives the operator executable. Converts + * between the iterator protocol and the operator executable protocol. + * Implemented as a separate class in anticipation of eventually + * changing the record batch (iterator) protocol. + */ + +public class OperatorDriver { + public enum State { + + /** + * Before the first call to next(). + */ + + START, + + /** + * The first call to next() has been made and schema (only) + * was returned. On the subsequent call to next(), return any + * data that might have accompanied that first batch. + */ + + SCHEMA, + + /** + * The second call to next() has been made and there is more + * data to deliver on subsequent calls. + */ + + RUN, + + /** + * No more data to deliver. + */ + + END, + + /** + * An error occurred. Operation was cancelled. + */ + + FAILED, + + /** + * close() called and resources are released. + */ + + CLOSED } + + private OperatorDriver.State state = State.START; + + /** + * Operator context. The driver "owns" the context and is responsible + * for closing it. + */ + + private final OperatorContext opContext; + private final OperatorExec operatorExec; + private final BatchAccessor batchAccessor; + private int schemaVersion; + + public OperatorDriver(OperatorContext opContext, OperatorExec opExec) { + this.opContext = opContext; + this.operatorExec = opExec; + batchAccessor = operatorExec.batchAccessor(); + } + + /** + * Get the next batch. Performs initialization on the first call. + * @return the iteration outcome to send downstream + */ + + public IterOutcome next() { + try { + switch (state) { + case START: + return start(); + case RUN: + return doNext(); + default: + OperatorRecordBatch.logger.debug("Extra call to next() in state " + state + ": " + operatorLabel()); + return IterOutcome.NONE; + } + } catch (UserException e) { + cancelSilently(); + state = State.FAILED; + throw e; + } catch (Throwable t) { + cancelSilently(); + state = State.FAILED; + throw UserException.executionError(t) + .addContext("Exception thrown from", operatorLabel()) + .build(OperatorRecordBatch.logger); + } + } + + /** + * Cancels the operator before reaching EOF. + */ + + public void cancel() { + try { + switch (state) { + case START: + case RUN: + cancelSilently(); + break; + default: + break; + } + } finally { + state = State.FAILED; --- End diff -- Added a Cancelled state. But, nothing ever reads that state. The point of FAILED is just to avoid confusion when calling `next()` after a failure or cancellation. We definitely *do not* want cancellation to move to the `CLOSED` state. This is a bug that exists in several operators. If `cancel()` closes the operator, then the operator is closed twice: once when the downstream operator says it wants no more rows, and a second time when the fragment executor does the real close. So, the `FAILED` state marks that a) we won't return any more rows, but that b) `close()` has not been called yet. The new `CANCELED` state has the same semantics. > Revised operator framework > -------------------------- > > Key: DRILL-6153 > URL: https://issues.apache.org/jira/browse/DRILL-6153 > Project: Apache Drill > Issue Type: Improvement > Reporter: Paul Rogers > Assignee: Paul Rogers > Priority: Major > Fix For: 1.13.0 > > > Adds the core operator framework which is the foundation for the revised scan operators. This is another incremental part of the batch sizing project. -- This message was sent by Atlassian JIRA (v7.6.3#76005)