From issues-return-49736-archive-asf-public=cust-asf.ponee.io@drill.apache.org Tue Feb 13 19:26:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8D04318067B for ; Tue, 13 Feb 2018 19:26:05 +0100 (CET) Received: (qmail 58317 invoked by uid 500); 13 Feb 2018 18:26:04 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 58308 invoked by uid 99); 13 Feb 2018 18:26:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Feb 2018 18:26:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2A6B3180160 for ; Tue, 13 Feb 2018 18:26:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.311 X-Spam-Level: X-Spam-Status: No, score=-109.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_LIVE=1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id OS4uwPCGwPOq for ; Tue, 13 Feb 2018 18:26:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B30EB5F39C for ; Tue, 13 Feb 2018 18:26:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CE4B6E023D for ; Tue, 13 Feb 2018 18:26:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 435BA2410A for ; Tue, 13 Feb 2018 18:26:00 +0000 (UTC) Date: Tue, 13 Feb 2018 18:26:00 +0000 (UTC) From: "Aman Sinha (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-6147) Limit batch size for Flat Parquet Reader MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-6147?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1636= 2833#comment-16362833 ]=20 Aman Sinha commented on DRILL-6147: ----------------------------------- =C2=A0 Regarding Paul's comment "Said another way, predicate push-down forces row-= by-row processing, even though the underlying storage format is columnar. (= This is why the Filter operator works row-by-row.)" This is not quite true, even though currently the Filter operator works thi= s way. =C2=A0As described in=C2=A0Daniel Abadi's blog on the columnar stora= ge formats [1],=C2=A0=C2=A0the vectorized processing of filter conditions y= ielded a 4x improvement for his (admittedly simple) experiment. =C2=A0We do= want to keep the option open for such enhancements. =C2=A0 I do agree with Paul on the more general point that we have to be able to h= andle efficient access to complex data (arrays, maps, repeated maps) withou= t running into memory situations. =C2=A0It sounds to me that an adaptive al= gorithm is needed where the scanner determines whether to use the 'bulk loa= ding columnar' read where appropriate while still allowing the 'result set = loader row-by-row' read for data that is complex types.=C2=A0 [1]=C2=A0[http://dbmsmusings.blogspot.com/2017/10/apache-arrow-vs-parquet-a= nd-orc-do-we.html,]=C2=A0 > Limit batch size for Flat Parquet Reader > ---------------------------------------- > > Key: DRILL-6147 > URL: https://issues.apache.org/jira/browse/DRILL-6147 > Project: Apache Drill > Issue Type: Improvement > Components: Storage - Parquet > Reporter: salim achouche > Assignee: salim achouche > Priority: Major > Fix For: 1.13.0 > > > The Parquet reader currently uses a hard-coded batch size limit (32k rows= ) when creating scan batches; there is no parameter nor any logic for contr= olling the amount of memory used. This enhancement will allow Drill to take= an extra input parameter to control direct memory usage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)