drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6174) Parquet pushdown planning improvements
Date Tue, 27 Feb 2018 15:43:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378794#comment-16378794
] 

ASF GitHub Bot commented on DRILL-6174:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1131#discussion_r170964343
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetPredicatesHelper.java
---
    @@ -0,0 +1,41 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p/>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p/>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.expr.stat;
    +
    +import org.apache.parquet.column.statistics.Statistics;
    +
    +/**
    + * Parquet predicates class helper for filter pushdown.
    + */
    +public class ParquetPredicatesHelper {
    +
    +  /**
    +   * Check does the column chunk's statistics have all nulls
    +   */
    +  static boolean isAllNulls(Statistics stat, long rowCount) {
    --- End diff --
    
    1. Please make helper method public as well. 
    2. Please add `@param` and `@return` with description to method javadoc.
    Please fix here and in method below.


> Parquet pushdown planning improvements
> --------------------------------------
>
>                 Key: DRILL-6174
>                 URL: https://issues.apache.org/jira/browse/DRILL-6174
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.12.0
>            Reporter: Arina Ielchiieva
>            Assignee: Roman Kulyk
>            Priority: Major
>              Labels: doc-impacting
>             Fix For: 1.13.0
>
>
> Currently parquet pushdown planning has certain limitations (https://drill.apache.org/docs/parquet-filter-pushdown/).
This Jira aims to fix some of them. List of improvements can be find below:
> 1. IS [NOT] NULL / TRUE / FALSE
> 2. Timestamp / date / time implicit / explicit casts
> {noformat}
> timestamp -> date
> timestamp -> varchar
> date -> timestamp
> date -> varchar
> time -> timestamp
> time -> date
> time -> varchar
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message