drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6148) TestSortSpillWithException is sometimes failing.
Date Tue, 13 Feb 2018 18:28:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362839#comment-16362839
] 

ASF GitHub Bot commented on DRILL-6148:
---------------------------------------

Github user HanumathRao commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1120#discussion_r167957209
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSortSpillWithException.java
---
    @@ -59,6 +59,7 @@ public static void setup() throws Exception {
         ClusterFixtureBuilder builder = ClusterFixture.builder(dirTestWatcher)
             .configProperty(ExecConstants.EXTERNAL_SORT_SPILL_THRESHOLD, 1) // Unmanaged
             .configProperty(ExecConstants.EXTERNAL_SORT_SPILL_GROUP_SIZE, 1) // Unmanaged
    +        .configProperty(ExecConstants.EXTERNAL_SORT_MAX_MEMORY, 10 * 1024 * 1024) //use
less memory for sorting.
    --- End diff --
    
    @paul-rogers  Thank you. I have added the comment for the testcase. Please let me know
if any other changes are required.


> TestSortSpillWithException is sometimes failing.
> ------------------------------------------------
>
>                 Key: DRILL-6148
>                 URL: https://issues.apache.org/jira/browse/DRILL-6148
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Tools, Build &amp; Test
>    Affects Versions: 1.12.0
>            Reporter: Hanumath Rao Maduri
>            Assignee: Hanumath Rao Maduri
>            Priority: Minor
>              Labels: ready-to-commit
>             Fix For: 1.13.0
>
>
> TestSortSpillWithException#testSpillLeakManaged is sometimes failing. However for some
reason this is being observed only in one of my branch. 
> TestSpillLeakManaged tests for leak when an exception is thrown during the spilling of
the rows in ExternalSort. In the test failure case it happens that ExternalSort is able to
sort the data with the given memory and not spill at all. Hence the injection interruption
path is not hit at all and hence no exception is thrown.
> The test case should use drill.exec.sort.external.mem_limit to force it to use as less
memory as possible so as to test the case.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message