drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6138) Move RecordBatchSizer to org.apache.drill.exec.record package
Date Tue, 06 Feb 2018 22:16:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354634#comment-16354634
] 

ASF GitHub Bot commented on DRILL-6138:
---------------------------------------

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1115#discussion_r166459971
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java
---
    @@ -260,7 +254,7 @@ public static ColumnSize getColumn(ValueVector v, String prefix) {
     
       public static final int MAX_VECTOR_SIZE = ValueVector.MAX_BUFFER_SIZE; // 16 MiB
     
    -  private List<ColumnSize> columnSizes = new ArrayList<>();
    +  private Map<String, ColumnSize> columnSizes = CaseInsensitiveMap.newHashMap();
    --- End diff --
    
    I'll rebase after this change goes in.


> Move RecordBatchSizer to org.apache.drill.exec.record package
> -------------------------------------------------------------
>
>                 Key: DRILL-6138
>                 URL: https://issues.apache.org/jira/browse/DRILL-6138
>             Project: Apache Drill
>          Issue Type: Task
>          Components: Execution - Flow
>    Affects Versions: 1.12.0
>            Reporter: Padma Penumarthy
>            Assignee: Padma Penumarthy
>            Priority: Minor
>             Fix For: 1.13.0
>
>
> Move RecordBatchSizer from org.apache.drill.exec.physical.impl.spill package to org.apache.drill.exec.record
package.
> Minor refactoring - change columnSizes from list to map. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message