drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6032) Use RecordBatchSizer to estimate size of columns in HashAgg
Date Thu, 01 Feb 2018 22:52:55 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349438#comment-16349438

ASF GitHub Bot commented on DRILL-6032:

Github user ilooner commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java
    @@ -255,7 +254,6 @@ private HashAggregator createAggregatorInternal() throws SchemaChangeException,
           groupByOutFieldIds[i] = container.add(vv);
    -    int extraNonNullColumns = 0; // each of SUM, MAX and MIN gets an extra bigint column
    --- End diff --
    Ok. I am going to move all the code into one place though. Previously half the code was
in HashAggBatch and the other half was in HashAggTemplate. I'll also add a comment that this
extra code should be removed after DRILL-5728, and I will also add a comment to DRILL-5728
to reminder the implementer to remove this extra code.

> Use RecordBatchSizer to estimate size of columns in HashAgg
> -----------------------------------------------------------
>                 Key: DRILL-6032
>                 URL: https://issues.apache.org/jira/browse/DRILL-6032
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>            Priority: Major
>             Fix For: 1.13.0
> We need to use the RecordBatchSize to estimate the size of columns in the Partition batches
created by HashAgg.

This message was sent by Atlassian JIRA

View raw message