From issues-return-48983-archive-asf-public=cust-asf.ponee.io@drill.apache.org Fri Jan 19 02:59:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id C032D18066D for ; Fri, 19 Jan 2018 02:59:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B0420160C26; Fri, 19 Jan 2018 01:59:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 09D40160C48 for ; Fri, 19 Jan 2018 02:59:03 +0100 (CET) Received: (qmail 45710 invoked by uid 500); 19 Jan 2018 01:59:03 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 45699 invoked by uid 99); 19 Jan 2018 01:59:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jan 2018 01:59:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D0C7C1A0B8E for ; Fri, 19 Jan 2018 01:59:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.711 X-Spam-Level: X-Spam-Status: No, score=-100.711 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 4yv0VjLmPRBH for ; Fri, 19 Jan 2018 01:59:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CA6015FB9F for ; Fri, 19 Jan 2018 01:59:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 422DFE0F6E for ; Fri, 19 Jan 2018 01:59:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AA4B22130A for ; Fri, 19 Jan 2018 01:59:00 +0000 (UTC) Date: Fri, 19 Jan 2018 01:59:00 +0000 (UTC) From: "Paul Rogers (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-6098) Make Drill Failure Handling Consistent MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-6098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331604#comment-16331604 ] Paul Rogers commented on DRILL-6098: ------------------------------------ Thanks for taking on this task! Posted a design document from an earlier attempt in case if offers any useful ideas. > Make Drill Failure Handling Consistent > -------------------------------------- > > Key: DRILL-6098 > URL: https://issues.apache.org/jira/browse/DRILL-6098 > Project: Apache Drill > Issue Type: Improvement > Reporter: Timothy Farkas > Assignee: Timothy Farkas > Priority: Major > Attachments: Drill Operator Error Handling Redesign.pdf > > > As described by [~Paul.Rogers] > " > We have multiple ways of reporting errors: > * Throw a UserException explaining the error > * Throw an unchecked exception and and let the fragment executor guess the cause. > * Return STOP > * Tell the fragment executor to fail. (A we also required to return STOP?) > * Return OUT_OF_MEMORY status > The proposal is to replace them all with a single solution: throw a UserException. Each operator catches other exceptions and translates them to UserException. > Java unwinds the stack just fine; no reason for us to write code to do it via STOP. > Then, the Fragment Executor calls close() on all operators. No reason to try to do this cleanup on STOP. (Even if we do, the lower-level operators won't have seen the STOP.) > Since failures are hard to test, and have cause no end of problems, having multiple ways to do the same thing is really not that helpful to Drill users. > " -- This message was sent by Atlassian JIRA (v7.6.3#76005)