From issues-return-48631-archive-asf-public=cust-asf.ponee.io@drill.apache.org Wed Jan 10 18:13:08 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 4AAFC18076D for ; Wed, 10 Jan 2018 18:13:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3A841160C23; Wed, 10 Jan 2018 17:13:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7F7D6160C2E for ; Wed, 10 Jan 2018 18:13:07 +0100 (CET) Received: (qmail 31144 invoked by uid 500); 10 Jan 2018 17:13:06 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 31135 invoked by uid 99); 10 Jan 2018 17:13:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 17:13:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 54DDFC1704 for ; Wed, 10 Jan 2018 17:13:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.711 X-Spam-Level: X-Spam-Status: No, score=-100.711 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id JuTnnnaie1yR for ; Wed, 10 Jan 2018 17:13:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6A2DB5F3D0 for ; Wed, 10 Jan 2018 17:13:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B8CD7E0373 for ; Wed, 10 Jan 2018 17:13:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 94046274D8 for ; Wed, 10 Jan 2018 17:13:02 +0000 (UTC) Date: Wed, 10 Jan 2018 17:13:02 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-6054) Issues in FindPartitionConditions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-6054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320662#comment-16320662 ] ASF GitHub Bot commented on DRILL-6054: --------------------------------------- Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/1078#discussion_r160741806 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java --- @@ -195,8 +195,16 @@ private void popOpStackAndBuildFilter() { * For all other operators we clear the children if one of the * children is a no push. */ - assert currentOp.getOp().getKind() == SqlKind.AND; - newFilter = currentOp.getChildren().get(0); + if (currentOp.getOp().getKind() == SqlKind.AND) { + newFilter = currentOp.getChildren().get(0); + for(OpState opState : opStack) { --- End diff -- done. > Issues in FindPartitionConditions > --------------------------------- > > Key: DRILL-6054 > URL: https://issues.apache.org/jira/browse/DRILL-6054 > Project: Apache Drill > Issue Type: Bug > Affects Versions: 1.12.0 > Reporter: Chunhui Shi > Assignee: Chunhui Shi > Fix For: 1.13.0 > > > When the condition is these cases, partition is not done correctly: > b = 3 OR (dir0 = 1 and a = 2) > not (dir0 = 1 AND b = 2) -- This message was sent by Atlassian JIRA (v6.4.14#64029)