From issues-return-48975-archive-asf-public=cust-asf.ponee.io@drill.apache.org Fri Jan 19 02:11:07 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id AC49718066D for ; Fri, 19 Jan 2018 02:11:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9B046160C26; Fri, 19 Jan 2018 01:11:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E8D5B160C48 for ; Fri, 19 Jan 2018 02:11:06 +0100 (CET) Received: (qmail 75646 invoked by uid 500); 19 Jan 2018 01:11:06 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 75601 invoked by uid 99); 19 Jan 2018 01:11:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jan 2018 01:11:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9303B1A00CE for ; Fri, 19 Jan 2018 01:11:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.711 X-Spam-Level: X-Spam-Status: No, score=-100.711 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id kzXcp1kd-9Ub for ; Fri, 19 Jan 2018 01:11:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 97EC35F341 for ; Fri, 19 Jan 2018 01:11:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 661DDE0CA3 for ; Fri, 19 Jan 2018 01:11:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 66E7821308 for ; Fri, 19 Jan 2018 01:11:01 +0000 (UTC) Date: Fri, 19 Jan 2018 01:11:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-6049) Rollup of hygiene changes from "batch size" project MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-6049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331545#comment-16331545 ] ASF GitHub Bot commented on DRILL-6049: --------------------------------------- Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1085#discussion_r162512667 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorStats.java --- @@ -278,22 +273,62 @@ public void addDoubleMetrics(OperatorProfile.Builder builder) { } } - @Override + /** + * Set a stat to the specified long value. Creates the stat + * if the stat does not yet exist. + * + * @param metric the metric to update + * @param value the value to set + */ + public void addLongStat(MetricDef metric, long value){ longMetrics.putOrAdd(metric.metricId(), value, value); } - @Override + @VisibleForTesting + public long getLongStat(MetricDef metric) { + return longMetrics.get(metric.metricId()); --- End diff -- Presumably fail. But, since this used in testing to ensure that a long metric was, in fact, written, failure is actually a useful result. > Rollup of hygiene changes from "batch size" project > --------------------------------------------------- > > Key: DRILL-6049 > URL: https://issues.apache.org/jira/browse/DRILL-6049 > Project: Apache Drill > Issue Type: Improvement > Affects Versions: 1.12.0 > Reporter: Paul Rogers > Assignee: Paul Rogers > Priority: Major > Fix For: 1.13.0 > > > PR to include all non-core changes related to the batch size project to allow simpler review of the core changes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)