drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6106) Use valueOf method instead of constructor since valueOf has a higher performance by caching frequently requested values.
Date Tue, 30 Jan 2018 21:26:02 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345836#comment-16345836
] 

ASF GitHub Bot commented on DRILL-6106:
---------------------------------------

Github user reudismam commented on the issue:

    https://github.com/apache/drill/pull/1099
  
    Since I have to resolve some conflicts after applying the edit, squashing could be tricky
because the commits are non-consecutive. I allowed the merging using the squashing option
in the forked project setting. Thus, when someone merges the pull request, he or she can decide
to squash the commits.
    
    ![image](https://user-images.githubusercontent.com/1970407/35592031-8fdf4aee-05ea-11e8-9446-cd88c1dd0fd0.png)



> Use valueOf method instead of constructor since valueOf has a higher performance by caching
frequently requested values.
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-6106
>                 URL: https://issues.apache.org/jira/browse/DRILL-6106
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.12.0
>            Reporter: Reudismam Rolim de Sousa
>            Assignee: Reudismam Rolim de Sousa
>            Priority: Minor
>              Labels: ready-to-commit
>             Fix For: 1.13.0
>
>
> Use valueOf method instead of constructor since valueOf has a higher performance by
caching frequently requested values.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message