drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6054) Issues in FindPartitionConditions
Date Wed, 10 Jan 2018 17:13:02 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320661#comment-16320661
] 

ASF GitHub Bot commented on DRILL-6054:
---------------------------------------

Github user chunhui-shi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1078#discussion_r160741771
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java
---
    @@ -228,13 +236,16 @@ private boolean isHolisticExpression(RexCall call) {
         return false;
       }
     
    +  protected boolean inputRefToPush(RexInputRef inputRef) {
    --- End diff --
    
    This is intentionally made to be 'protected' for future extension.
    Right now, FindPartitionCondition use position based inputRef(using BitSet dirs) to mark
which inputRef should be pushed. But in future, we may use name based policy to decide which
one to push. 


> Issues in FindPartitionConditions
> ---------------------------------
>
>                 Key: DRILL-6054
>                 URL: https://issues.apache.org/jira/browse/DRILL-6054
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.12.0
>            Reporter: Chunhui Shi
>            Assignee: Chunhui Shi
>             Fix For: 1.13.0
>
>
> When the condition is these cases, partition is not done correctly: 
> b = 3 OR (dir0 = 1 and a = 2)
> not (dir0 = 1 AND b = 2)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message