drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6049) Rollup of hygiene changes from "batch size" project
Date Fri, 19 Jan 2018 01:11:01 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331545#comment-16331545
] 

ASF GitHub Bot commented on DRILL-6049:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1085#discussion_r162512667
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorStats.java ---
    @@ -278,22 +273,62 @@ public void addDoubleMetrics(OperatorProfile.Builder builder) {
         }
       }
     
    -  @Override
    +  /**
    +   * Set a stat to the specified long value. Creates the stat
    +   * if the stat does not yet exist.
    +   *
    +   * @param metric the metric to update
    +   * @param value the value to set
    +   */
    +
       public void addLongStat(MetricDef metric, long value){
         longMetrics.putOrAdd(metric.metricId(), value, value);
       }
     
    -  @Override
    +  @VisibleForTesting
    +  public long getLongStat(MetricDef metric) {
    +    return longMetrics.get(metric.metricId());
    --- End diff --
    
    Presumably fail. But, since this used in testing to ensure that a long metric was, in
fact, written, failure is actually a useful result.


> Rollup of hygiene changes from "batch size" project
> ---------------------------------------------------
>
>                 Key: DRILL-6049
>                 URL: https://issues.apache.org/jira/browse/DRILL-6049
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.12.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Major
>             Fix For: 1.13.0
>
>
> PR to include all non-core changes related to the batch size project to allow simpler
review of the core changes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message