drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6032) Use RecordBatchSizer to estimate size of columns in HashAgg
Date Tue, 30 Jan 2018 01:18:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344347#comment-16344347
] 

ASF GitHub Bot commented on DRILL-6032:
---------------------------------------

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1101#discussion_r164615997
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/agg/TestHashAggrSpill.java
---
    @@ -53,59 +51,54 @@
       @Rule
       public final BaseDirTestWatcher dirTestWatcher = new BaseDirTestWatcher();
     
    -    /**
    -     *  A template for Hash Aggr spilling tests
    -     *
    -     * @throws Exception
    -     */
    -    private void testSpill(long maxMem, long numPartitions, long minBatches, int maxParallel,
boolean fallback ,boolean predict,
    -                           String sql, long expectedRows, int cycle, int fromPart, int
toPart) throws Exception {
    -        LogFixture.LogFixtureBuilder logBuilder = LogFixture.builder()
    --- End diff --
    
    I can add this back. In general I don't like leaving unused code in the codebase though.


> Use RecordBatchSizer to estimate size of columns in HashAgg
> -----------------------------------------------------------
>
>                 Key: DRILL-6032
>                 URL: https://issues.apache.org/jira/browse/DRILL-6032
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>            Priority: Major
>             Fix For: 1.13.0
>
>
> We need to use the RecordBatchSize to estimate the size of columns in the Partition batches
created by HashAgg.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message