drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-6032) Use RecordBatchSizer to estimate size of columns in HashAgg
Date Tue, 30 Jan 2018 01:12:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344338#comment-16344338
] 

ASF GitHub Bot commented on DRILL-6032:
---------------------------------------

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1101#discussion_r164615077
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
    @@ -129,11 +143,16 @@ public ColumnSize(ValueVector v, String prefix) {
             // No standard size for Union type
             dataSize = v.getPayloadByteCount(valueCount);
             break;
    +      case GENERIC_OBJECT:
    +        // We cannot provide a size for Generic Objects
    --- End diff --
    
    Execution gets here in some of the HashAgg functional tests. Probably in the case where
varchars are aggregated, since as you explained to me varchars are stored in object vectors
on heap.


> Use RecordBatchSizer to estimate size of columns in HashAgg
> -----------------------------------------------------------
>
>                 Key: DRILL-6032
>                 URL: https://issues.apache.org/jira/browse/DRILL-6032
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>            Priority: Major
>             Fix For: 1.13.0
>
>
> We need to use the RecordBatchSize to estimate the size of columns in the Partition batches
created by HashAgg.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message