drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5993) Add Generic Copiers
Date Sat, 20 Jan 2018 03:13:01 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333153#comment-16333153
] 

ASF GitHub Bot commented on DRILL-5993:
---------------------------------------

Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1057#discussion_r162771857
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/GenericSV4Copier.java
---
    @@ -0,0 +1,68 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.physical.impl.svremover;
    +
    +import org.apache.drill.exec.exception.SchemaChangeException;
    +import org.apache.drill.exec.ops.FragmentContext;
    +import org.apache.drill.exec.record.RecordBatch;
    +import org.apache.drill.exec.record.VectorContainer;
    +import org.apache.drill.exec.record.VectorWrapper;
    +import org.apache.drill.exec.vector.SchemaChangeCallBack;
    +import org.apache.drill.exec.vector.ValueVector;
    +
    +public class GenericSV4Copier extends AbstractSV4Copier {
    +
    +  @Override
    +  public void setup(RecordBatch incoming, VectorContainer outgoing) throws SchemaChangeException
{
    +    super.setup(incoming, outgoing);
    --- End diff --
    
    Can the setup() code in both GenericSV2Copier and GenericSV4Copier be moved up into the
setup() method of AbstractCopier ?  Both codes are identical ....



> Add Generic Copiers
> -------------------
>
>                 Key: DRILL-5993
>                 URL: https://issues.apache.org/jira/browse/DRILL-5993
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>            Priority: Major
>
> Currently the copier can only copy record from an incoming batch to the beginning of
an outgoing batch. We need to be able to copy a record and append it to the end of the outgoing
batch. Also Paul's Generic copiers are more performant and simpler and should be added.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message