drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5730) Fix Unit Test failures on JDK 8 And Some JDK 7 versions
Date Thu, 18 Jan 2018 23:07:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331403#comment-16331403
] 

ASF GitHub Bot commented on DRILL-5730:
---------------------------------------

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1045#discussion_r162496772
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/OperatorFixture.java ---
    @@ -86,37 +117,35 @@
      * <li>Multiple threads of execution.</li>
      * </ul>
      */
    -
     public class OperatorFixture extends BaseFixture implements AutoCloseable {
     
    +  public OperatorContext operatorContext(PhysicalOperator config) {
    +    return new MockOperatorContext(context, allocator(), config);
    +  }
    +
       /**
        * Builds an operator fixture based on a set of config options and system/session
        * options.
        */
    -
    -  public static class OperatorFixtureBuilder
    +  public static class Builder
    --- End diff --
    
    There are no collisions. Java has a nice syntax for handling names like this. Specifically
you can use this name for the class **OperatorFixture.Builder** in all your variable declarations.
This removes the redundancy of prefixing the name of an inner class with the name of the outer
class. 


> Fix Unit Test failures on JDK 8 And Some JDK 7 versions
> -------------------------------------------------------
>
>                 Key: DRILL-5730
>                 URL: https://issues.apache.org/jira/browse/DRILL-5730
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>            Priority: Major
>
> Tests fail on JDK 8 and oracle JDK 7 on my mac
> Failed tests: 
>   TestMetadataProvider.tables:153 expected:<OK> but was:<FAILED>
>   TestMetadataProvider.tablesWithTableNameFilter:212 expected:<OK> but was:<FAILED>
>   TestMetadataProvider.tablesWithSystemTableFilter:187 expected:<OK> but was:<FAILED>
>   TestMetadataProvider.tablesWithTableFilter:176 expected:<OK> but was:<FAILED>
> Tests in error: 
>   TestInfoSchema.selectFromAllTables » UserRemote SYSTEM ERROR: URISyntaxExcepti...
>   TestCustomUserAuthenticator.positiveUserAuth » UserRemote SYSTEM ERROR: URISyn...
>   TestCustomUserAuthenticator.positiveUserAuthAfterNegativeUserAuth » UserRemote
>   TestViewSupport.infoSchemaWithView:350->BaseTestQuery.testRunAndReturn:344 » Rpc
>   TestParquetScan.testSuccessFile:58->BaseTestQuery.testRunAndReturn:344 » Rpc o...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message