drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5971) Fix INT64, INT32 logical types in complex parquet reader
Date Tue, 26 Dec 2017 13:17:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303833#comment-16303833
] 

ASF GitHub Bot commented on DRILL-5971:
---------------------------------------

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1049#discussion_r158703375
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetComplex.java
---
    @@ -193,4 +200,168 @@ public void notxistsField() throws Exception {
             .run();
       }
     
    +  @Test //DRILL-5971
    +  public void testComplexLogicalIntTypes() throws Exception {
    +    String query = String.format("select t.complextype as complextype,  " +
    +            "t.uint_64 as uint_64, t.uint_32 as uint_32, t.uint_16 as uint_16, t.uint_8
as uint_8,  " +
    +            "t.int_64 as int_64, t.int_32 as int_32, t.int_16 as int_16, t.int_8 as int_8
 " +
    +            "from cp.`store/parquet/complex/logical_int_complex.parquet` t" );
    +    String[] columns = {"complextype", "uint_64", "uint_32", "uint_16", "uint_8", "int_64",
"int_32", "int_16", "int_8" };
    +    testBuilder()
    +        .sqlQuery(query)
    +        .unOrdered()
    +        .baselineColumns(columns)
    +        .baselineValues( mapOf("a","a","b","b")  , 0L                   , 0         
 , 0        , 0       , 0L                    , 0            , 0       ,0       )
    --- End diff --
    
    Please remove space before `mapOf` and remove all spaces before commas.


> Fix INT64, INT32 logical types in complex parquet reader
> --------------------------------------------------------
>
>                 Key: DRILL-5971
>                 URL: https://issues.apache.org/jira/browse/DRILL-5971
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.11.0
>            Reporter: Parth Chandra
>            Assignee: Parth Chandra
>             Fix For: 1.13.0
>
>
> The 'complex' Parquet reader does not recognize the Parquet logical types INT64, and
INT32. 
> Should be a simple change to add these logical types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message