drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5730) Fix Unit Test failures on JDK 8 And Some JDK 7 versions
Date Tue, 12 Dec 2017 00:47:03 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286876#comment-16286876
] 

ASF GitHub Bot commented on DRILL-5730:
---------------------------------------

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1045#discussion_r156244298
  
    --- Diff: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcBatchCreator.java
---
    @@ -33,10 +32,10 @@
     public class JdbcBatchCreator implements BatchCreator<JdbcSubScan> {
       @Override
       public ScanBatch getBatch(FragmentContext context, JdbcSubScan config,
    -      List<RecordBatch> children) throws ExecutionSetupException {
    +                            List<RecordBatch> children) throws ExecutionSetupException
{
         Preconditions.checkArgument(children.isEmpty());
         JdbcStoragePlugin plugin = config.getPlugin();
    -    RecordReader reader = new JdbcRecordReader(context, plugin.getSource(), config.getSql(),
plugin.getName());
    +    RecordReader reader = new JdbcRecordReader(plugin.getSource(), config.getSql(), plugin.getName());
    --- End diff --
    
    Which file did I remove the POP config from? I can't seem to find it.


> Fix Unit Test failures on JDK 8 And Some JDK 7 versions
> -------------------------------------------------------
>
>                 Key: DRILL-5730
>                 URL: https://issues.apache.org/jira/browse/DRILL-5730
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>
> Tests fail on JDK 8 and oracle JDK 7 on my mac
> Failed tests: 
>   TestMetadataProvider.tables:153 expected:<OK> but was:<FAILED>
>   TestMetadataProvider.tablesWithTableNameFilter:212 expected:<OK> but was:<FAILED>
>   TestMetadataProvider.tablesWithSystemTableFilter:187 expected:<OK> but was:<FAILED>
>   TestMetadataProvider.tablesWithTableFilter:176 expected:<OK> but was:<FAILED>
> Tests in error: 
>   TestInfoSchema.selectFromAllTables » UserRemote SYSTEM ERROR: URISyntaxExcepti...
>   TestCustomUserAuthenticator.positiveUserAuth » UserRemote SYSTEM ERROR: URISyn...
>   TestCustomUserAuthenticator.positiveUserAuthAfterNegativeUserAuth » UserRemote
>   TestViewSupport.infoSchemaWithView:350->BaseTestQuery.testRunAndReturn:344 » Rpc
>   TestParquetScan.testSuccessFile:58->BaseTestQuery.testRunAndReturn:344 » Rpc o...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message