drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5730) Fix Unit Test failures on JDK 8 And Some JDK 7 versions
Date Mon, 11 Dec 2017 20:48:03 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286532#comment-16286532
] 

ASF GitHub Bot commented on DRILL-5730:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1045#discussion_r156176534
  
    --- Diff: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcBatchCreator.java
---
    @@ -33,10 +32,10 @@
     public class JdbcBatchCreator implements BatchCreator<JdbcSubScan> {
       @Override
       public ScanBatch getBatch(FragmentContext context, JdbcSubScan config,
    -      List<RecordBatch> children) throws ExecutionSetupException {
    +                            List<RecordBatch> children) throws ExecutionSetupException
{
         Preconditions.checkArgument(children.isEmpty());
         JdbcStoragePlugin plugin = config.getPlugin();
    -    RecordReader reader = new JdbcRecordReader(context, plugin.getSource(), config.getSql(),
plugin.getName());
    +    RecordReader reader = new JdbcRecordReader(plugin.getSource(), config.getSql(), plugin.getName());
    --- End diff --
    
    For readers that don't need the fragment context, it is certainly helpful, for unit testing,
to omit it. However, operator context seems fair game. The operator context provides the Drill
file system, the physical operator definition (the "config" here) and so on. Unfortunately,
it is created inside the `ScanBatch`, to late to pass to the reader constructor.
    
    The new scan framework from the "batch size" project addresses these issues; but only
for those few readers that we choose to upgrade; most readers will continue to use the changes
you are making here.
    
    One other point: in an earlier file, you removed the physical operator definition (AKA
"POP config") from the `ScanBatch` constructor. Here you leave it. Will this cause unexpected
modes in which sometimes the operator definition is available, other times not?


> Fix Unit Test failures on JDK 8 And Some JDK 7 versions
> -------------------------------------------------------
>
>                 Key: DRILL-5730
>                 URL: https://issues.apache.org/jira/browse/DRILL-5730
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>
> Tests fail on JDK 8 and oracle JDK 7 on my mac
> Failed tests: 
>   TestMetadataProvider.tables:153 expected:<OK> but was:<FAILED>
>   TestMetadataProvider.tablesWithTableNameFilter:212 expected:<OK> but was:<FAILED>
>   TestMetadataProvider.tablesWithSystemTableFilter:187 expected:<OK> but was:<FAILED>
>   TestMetadataProvider.tablesWithTableFilter:176 expected:<OK> but was:<FAILED>
> Tests in error: 
>   TestInfoSchema.selectFromAllTables » UserRemote SYSTEM ERROR: URISyntaxExcepti...
>   TestCustomUserAuthenticator.positiveUserAuth » UserRemote SYSTEM ERROR: URISyn...
>   TestCustomUserAuthenticator.positiveUserAuthAfterNegativeUserAuth » UserRemote
>   TestViewSupport.infoSchemaWithView:350->BaseTestQuery.testRunAndReturn:344 » Rpc
>   TestParquetScan.testSuccessFile:58->BaseTestQuery.testRunAndReturn:344 » Rpc o...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message