Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Wed, 22 Nov 2017 22:00:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.13084392.1499138254000.304298.1511388000237@Atlassian.JIRA>
In-Reply-To: <JIRA.13084392.1499138254000@Atlassian.JIRA>
References: <JIRA.13084392.1499138254000@Atlassian.JIRA> <JIRA.13084392.1499138254215@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DRILL-5657) Implement size-aware result set
 loader
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 22 Nov 2017 22:00:05 -0000


    [ https://issues.apache.org/jira/browse/DRILL-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263418#comment-16263418 ] 

ASF GitHub Bot commented on DRILL-5657:
---------------------------------------

Github user paul-rogers commented on the issue:

    https://github.com/apache/drill/pull/914
  
    Addressed Karthik's comments, rebased on master, resolved conflicts, and squashed all but the conflict resolution commit.


> Implement size-aware result set loader
> --------------------------------------
>
>                 Key: DRILL-5657
>                 URL: https://issues.apache.org/jira/browse/DRILL-5657
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: Future
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>             Fix For: Future
>
>
> A recent extension to Drill's set of test tools created a "row set" abstraction to allow us to create, and verify, record batches with very few lines of code. Part of this work involved creating a set of "column accessors" in the vector subsystem. Column readers provide a uniform API to obtain data from columns (vectors), while column writers provide a uniform writing interface.
> DRILL-5211 discusses a set of changes to limit value vectors to 16 MB in size (to avoid memory fragmentation due to Drill's two memory allocators.) The column accessors have proven to be so useful that they will be the basis for the new, size-aware writers used by Drill's record readers.
> A step in that direction is to retrofit the column writers to use the size-aware {{setScalar()}} and {{setArray()}} methods introduced in DRILL-5517.
> Since the test framework row set classes are (at present) the only consumer of the accessors, those classes must also be updated with the changes.
> This then allows us to add a new "row mutator" class that handles size-aware vector writing, including the case in which a vector fills in the middle of a row.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)