Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Wed, 1 Nov 2017 02:55:01 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12913306.1447679853000.118167.1509504901921@Atlassian.JIRA>
In-Reply-To: <JIRA.12913306.1447679853000@Atlassian.JIRA>
References: <JIRA.12913306.1447679853000@Atlassian.JIRA> <JIRA.12913306.1447679853688@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DRILL-4091) Support more functions in gis
 contrib module
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 01 Nov 2017 02:55:11 -0000


    [ https://issues.apache.org/jira/browse/DRILL-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233591#comment-16233591 ] 

ASF GitHub Bot commented on DRILL-4091:
---------------------------------------

Github user cgivre commented on a diff in the pull request:

    https://github.com/apache/drill/pull/258#discussion_r148172580
  
    --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STUnionAggregate.java ---
    @@ -0,0 +1,114 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.expr.fn.impl.gis;
    +
    +import javax.inject.Inject;
    +
    +import org.apache.drill.exec.expr.DrillAggFunc;
    +import org.apache.drill.exec.expr.annotations.FunctionTemplate;
    +import org.apache.drill.exec.expr.annotations.Output;
    +import org.apache.drill.exec.expr.annotations.Param;
    +import org.apache.drill.exec.expr.annotations.Workspace;
    +import org.apache.drill.exec.expr.holders.BigIntHolder;
    +import org.apache.drill.exec.expr.holders.IntHolder;
    +import org.apache.drill.exec.expr.holders.NullableVarBinaryHolder;
    +import org.apache.drill.exec.expr.holders.ObjectHolder;
    +import org.apache.drill.exec.expr.holders.UInt1Holder;
    +
    +import com.esri.core.geometry.SpatialReference;
    +
    +import io.netty.buffer.DrillBuf;
    +
    +@FunctionTemplate(name = "st_unionaggregate", scope = FunctionTemplate.FunctionScope.POINT_AGGREGATE)
    --- End diff --
    
    Do you want to include NULL handling here?


> Support more functions in gis contrib module
> --------------------------------------------
>
>                 Key: DRILL-4091
>                 URL: https://issues.apache.org/jira/browse/DRILL-4091
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Functions - Drill
>            Reporter: Karol Potocki
>            Priority: Major
>
> Support for commonly used gis functions in gis contrib module: relate, contains, crosses, intersects, touches, difference, disjoint, buffer, union etc.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)