drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5993) Allow Copier to Copy a Record and Append to the End of an Outgoing Batch
Date Thu, 30 Nov 2017 00:46:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271912#comment-16271912
] 

ASF GitHub Bot commented on DRILL-5993:
---------------------------------------

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1057#discussion_r153958856
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/record/TestVectorContainer.java
---
    @@ -124,4 +132,52 @@ public void testContainerMerge() {
         leftIndirect.clear();
         right.clear();
       }
    +
    +  @Test
    +  public void testAppendRow()
    +  {
    +    MaterializedField colA = MaterializedField.create("colA", Types.required(TypeProtos.MinorType.INT));
    +    MaterializedField colB = MaterializedField.create("colB", Types.required(TypeProtos.MinorType.INT));
    --- End diff --
    
    Added more interesting types. Currently RowSet classes don't support the Map data type.
Paul asked me to look into adding support for this a while ago for DRILL-5870 . I'll update
the test framework to support that in the next PR.


> Allow Copier to Copy a Record and Append to the End of an Outgoing Batch
> ------------------------------------------------------------------------
>
>                 Key: DRILL-5993
>                 URL: https://issues.apache.org/jira/browse/DRILL-5993
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>
> Currently the copier can only copy record from an incoming batch to the beginning of
an outgoing batch. We need to be able to copy a record and append it to the end of the outgoing
batch.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message