drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5981) Add Syntax Highlighting and Error Checking to Storage Plugin Config Page
Date Wed, 22 Nov 2017 18:52:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263137#comment-16263137

ASF GitHub Bot commented on DRILL-5981:

Github user cgivre commented on the issue:

    I made the requested fixes, and attempted to squash the commits into one, but failed on
that last step. I actually renamed the js director `ace-code-editor`, which seemed descriptive
to me. 

> Add Syntax Highlighting and Error Checking to Storage Plugin Config Page
> ------------------------------------------------------------------------
>                 Key: DRILL-5981
>                 URL: https://issues.apache.org/jira/browse/DRILL-5981
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>    Affects Versions: 1.12.0
>            Reporter: Charles Givre
>              Labels: easyfix
> When configuring storage plugins, it is easy to make a trivial mistake such as missing
a comma or paren, and then spend a great deal of time trying to find that.  This PR adds syntax
highlighting and error checking to the storage plugin page to prevent that. 
> Note, I work on a closed network and I have included the bare minimum of javascript libraries
needed for this task.  I did include them directly in the PR because I will not be able to
build Drill if I have to download them directly during the build process.

This message was sent by Atlassian JIRA

View raw message