drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5923) State of a successfully completed query shown as "COMPLETED"
Date Sun, 05 Nov 2017 16:08:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239607#comment-16239607
] 

ASF GitHub Bot commented on DRILL-5923:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1021#discussion_r148961643
  
    --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
    @@ -135,6 +135,8 @@ table.sortable thead .sorting_desc { background-image: url("/static/img/black-de
     
       <#assign queueName = model.getProfile().getQueueName() />
       <#assign queued = queueName != "" && queueName != "-" />
    +  <#assign queryStateDisplayName = ["Starting", "Running", "Succeeded", "Canceled",
"Failed",
    --- End diff --
    
    Maybe you can create common freemarker function which list.ftl and profile.ftl will use
to decode the state name thus we won't duplicate display names and always be sure they are
in sync.


> State of a successfully completed query shown as "COMPLETED"
> ------------------------------------------------------------
>
>                 Key: DRILL-5923
>                 URL: https://issues.apache.org/jira/browse/DRILL-5923
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - HTTP
>    Affects Versions: 1.11.0
>            Reporter: Prasad Nagaraj Subramanya
>            Assignee: Prasad Nagaraj Subramanya
>             Fix For: 1.12.0
>
>
> Drill UI currently lists a successfully completed query as "COMPLETED". Successfully
completed, failed and canceled queries are all grouped as Completed queries. 
> It would be better to list the state of a successfully completed query as "Succeeded"
to avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message