drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5922) Intermittent Memory Leaks in the ROOT allocator
Date Fri, 03 Nov 2017 20:26:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238300#comment-16238300
] 

ASF GitHub Bot commented on DRILL-5922:
---------------------------------------

GitHub user ilooner opened a pull request:

    https://github.com/apache/drill/pull/1023

    DRILL-5922 Fixed Child Allocator Lead. DRILL-5926 Stabalize TestValueVector tests.

    ##DRILL-5922
    
     - QueryContext was never closed when the Foreman finished. So the query child allocator
was never closed.
     - The PlanSplitter created a QueryContext temporarily to construct an RPC message but
never closed it.
     - The waitForExit method was error prone. Changed it to use the standard condition variable
pattern.
    
    ##DRILL-5926
    
    The TestValueVector tests would run out of memory. I simple increased the MaxDirectMemorySize
for the forked test processes in the pom to avoid this.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ilooner/drill DRILL-5922

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1023.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1023
    
----
commit f4058a93e70b21328f1f06e1e1ede5451d00b499
Author: Timothy Farkas <timothyfarkas@apache.org>
Date:   2017-11-02T18:27:56Z

     - Deleted commented out code in unit test

commit 56fd6929d3ef738e1d756c067e4e4f80cf965e37
Author: Timothy Farkas <timothyfarkas@apache.org>
Date:   2017-11-02T20:34:47Z

     - Removed non-existant parameter from java docs

commit a32c3bed4cf52f15bcf2d0e284c04329827b32b7
Author: Timothy Farkas <timothyfarkas@apache.org>
Date:   2017-11-03T16:11:04Z

     - Initial attempt at fix

commit c0afcc8853e4449ec5d7de6dfeee51efc8ad70ab
Author: Timothy Farkas <timothyfarkas@apache.org>
Date:   2017-11-03T18:19:08Z

     - Fixed hanging unit tests

commit d1cd5672e1da1553b0d8cf94c5b3c47354d417a3
Author: Timothy Farkas <timothyfarkas@apache.org>
Date:   2017-11-03T18:28:47Z

     - More wait to exit improvements

commit ce3a9555482b02a19579c2388a65c4dd29353588
Author: Timothy Farkas <timothyfarkas@apache.org>
Date:   2017-11-03T19:14:24Z

     - Deleted unused logger
     - Increased direct memory to prevent TestValueVector tests from running out of memory

----


> Intermittent Memory Leaks in the ROOT allocator  
> -------------------------------------------------
>
>                 Key: DRILL-5922
>                 URL: https://issues.apache.org/jira/browse/DRILL-5922
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>            Priority: Minor
>
> This issue was originall found by [~ben-zvi]. I am able to consistently reproduce the
error on my laptop by running the following unit test:
> org.apache.drill.exec.DrillSeparatePlanningTest#testMultiMinorFragmentComplexQuery
> {code}
> java.lang.IllegalStateException: Allocator[ROOT] closed with outstanding child allocators.
> Allocator(ROOT) 0/1048576/10113536/3221225472 (res/actual/peak/limit)
>   child allocators: 1
>     Allocator(query:26049b50-0cec-0a92-437c-bbe486e1fcbf) 1048576/0/0/268435456 (res/actual/peak/limit)
>       child allocators: 0
>       ledgers: 0
>       reservations: 0
>   ledgers: 0
>   reservations: 0
> 	at org.apache.drill.exec.memory.BaseAllocator.close(BaseAllocator.java:496) ~[classes/:na]
> 	at org.apache.drill.common.AutoCloseables.close(AutoCloseables.java:76) [classes/:na]
> 	at org.apache.drill.common.AutoCloseables.close(AutoCloseables.java:64) [classes/:na]
> 	at org.apache.drill.exec.server.BootStrapContext.close(BootStrapContext.java:256) ~[classes/:na]
> 	at org.apache.drill.common.AutoCloseables.close(AutoCloseables.java:76) [classes/:na]
> 	at org.apache.drill.common.AutoCloseables.close(AutoCloseables.java:64) [classes/:na]
> 	at org.apache.drill.exec.server.Drillbit.close(Drillbit.java:205) [classes/:na]
> 	at org.apache.drill.BaseTestQuery.closeClient(BaseTestQuery.java:315) [test-classes/:na]
> 	at org.apache.drill.BaseTestQuery.updateTestCluster(BaseTestQuery.java:157) [test-classes/:na]
> 	at org.apache.drill.BaseTestQuery.updateTestCluster(BaseTestQuery.java:148) [test-classes/:na]
> 	at org.apache.drill.exec.DrillSeparatePlanningTest.getFragmentsHelper(DrillSeparatePlanningTest.java:185)
[test-classes/:na]
> 	at org.apache.drill.exec.DrillSeparatePlanningTest.testMultiMinorFragmentComplexQuery(DrillSeparatePlanningTest.java:108)
[test-classes/:na]
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_144]
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_144]
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[na:1.8.0_144]
> 	at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_144]
> 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
[junit-4.11.jar:na]
> 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
[junit-4.11.jar:na]
> 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
[junit-4.11.jar:na]
> 	at mockit.integration.junit4.internal.JUnit4TestRunnerDecorator.executeTestMethod(JUnit4TestRunnerDecorator.java:120)
[jmockit-1.3.jar:na]
> 	at mockit.integration.junit4.internal.JUnit4TestRunnerDecorator.invokeExplosively(JUnit4TestRunnerDecorator.java:65)
[jmockit-1.3.jar:na]
> 	at mockit.integration.junit4.internal.MockFrameworkMethod.invokeExplosively(MockFrameworkMethod.java:29)
[jmockit-1.3.jar:na]
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_144]
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_144]
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[na:1.8.0_144]
> 	at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_144]
> 	at mockit.internal.util.MethodReflection.invokeWithCheckedThrows(MethodReflection.java:95)
[jmockit-1.3.jar:na]
> 	at mockit.internal.annotations.MockMethodBridge.callMock(MockMethodBridge.java:76) [jmockit-1.3.jar:na]
> 	at mockit.internal.annotations.MockMethodBridge.invoke(MockMethodBridge.java:41) [jmockit-1.3.jar:na]
> 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java) [junit-4.11.jar:na]
> 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
[junit-4.11.jar:na]
> 	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
[junit-4.11.jar:na]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message