drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5919) Add non-numeric support for JSON processing
Date Fri, 10 Nov 2017 23:49:01 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248195#comment-16248195
] 

ASF GitHub Bot commented on DRILL-5919:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1026#discussion_r150359992
  
    --- Diff: contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java
---
    @@ -73,6 +73,7 @@
       private final MongoStoragePlugin plugin;
     
       private final boolean enableAllTextMode;
    +  private final boolean enableNonNumericNumbers;
    --- End diff --
    
    Would recommend: `enableNanInf`.
    
    "Non-numeric numbers" sounds like we might allow "foo" or "thirteen".


> Add non-numeric support for JSON processing
> -------------------------------------------
>
>                 Key: DRILL-5919
>                 URL: https://issues.apache.org/jira/browse/DRILL-5919
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - JSON
>    Affects Versions: 1.11.0
>            Reporter: Volodymyr Tkach
>            Assignee: Volodymyr Tkach
>              Labels: doc-impacting
>             Fix For: Future
>
>
> Add session options to allow drill working with non standard json strings number literals
like: NaN, Infinity, -Infinity. By default these options will be switched off, the user will
be able to toggle them during working session.
> *For documentation*
> 1. Added two session options {{store.json.reader.non_numeric_numbers}} and {{store.json.reader.non_numeric_numbers}}
that allow to read/write NaN and Infinity as numbers. By default these options are set to
false.
> 2. Extended signature of {{convert_toJSON}} and {{convert_fromJSON}} functions by adding
second optional parameter that enables read/write NaN and Infinity.
> For example:
> {noformat}
> select convert_fromJSON('{"key": NaN}') from (values(1)); will result with JsonParseException,
but
> select convert_fromJSON('{"key": NaN}', true) from (values(1)); will parse NaN as a number.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message