drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5337) OpenTSDB storage plugin
Date Sun, 05 Nov 2017 13:39:08 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239540#comment-16239540
] 

ASF GitHub Bot commented on DRILL-5337:
---------------------------------------

Github user Vlad-Storona commented on a diff in the pull request:

    https://github.com/apache/drill/pull/774#discussion_r148957508
  
    --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/client/Schema.java
---
    @@ -0,0 +1,119 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.openTSDB.client;
    +
    +import org.apache.drill.exec.store.openTSDB.dto.ColumnDTO;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.HashMap;
    +import java.util.List;
    +
    +import static org.apache.drill.exec.store.openTSDB.Constants.*;
    +import static org.apache.drill.exec.store.openTSDB.Util.getValidTableName;
    +import static org.apache.drill.exec.store.openTSDB.client.Schema.DefaultColumns.AGGREGATED_VALUE;
    +import static org.apache.drill.exec.store.openTSDB.client.Schema.DefaultColumns.AGGREGATE_TAGS;
    +import static org.apache.drill.exec.store.openTSDB.client.Schema.DefaultColumns.METRIC;
    +import static org.apache.drill.exec.store.openTSDB.client.Schema.DefaultColumns.TIMESTAMP;
    +
    +/**
    + * Abstraction for representing structure of openTSDB table
    + */
    +public class Schema {
    +
    +  private static final Logger log =
    +      LoggerFactory.getLogger(Schema.class);
    +
    +  private final List<ColumnDTO> columns = new ArrayList<>();
    +  private final Service db;
    +  private final String name;
    +
    +  public Schema(Service db, String name) {
    +    this.db = db;
    +    this.name = name;
    +    setupStructure();
    +  }
    +
    +  private void setupStructure() {
    +    columns.add(new ColumnDTO(METRIC.toString(), OpenTSDBTypes.STRING));
    +    columns.add(new ColumnDTO(AGGREGATE_TAGS.toString(), OpenTSDBTypes.STRING));
    +    columns.add(new ColumnDTO(TIMESTAMP.toString(), OpenTSDBTypes.TIMESTAMP));
    +    columns.add(new ColumnDTO(AGGREGATED_VALUE.toString(), OpenTSDBTypes.DOUBLE));
    +    columns.addAll(db.getUnfixedColumns(getParamsForQuery()));
    +  }
    +
    +  /**
    +   * Return list with all columns names and its types
    +   *
    +   * @return List<ColumnDTO>
    +   */
    +  public List<ColumnDTO> getColumns() {
    +    return Collections.unmodifiableList(columns);
    +  }
    +
    +  /**
    +   * Number of columns in table
    +   *
    +   * @return number of table columns
    +   */
    +  public int getColumnCount() {
    +    return columns.size();
    +  }
    +
    +  /**
    +   * @param columnIndex index of required column in table
    +   * @return ColumnDTO
    +   */
    +  public ColumnDTO getColumnByIndex(int columnIndex) {
    +    return columns.get(columnIndex);
    +  }
    +
    +  // Create map with required params, for querying metrics.
    +  // Without this params, we cannot make API request to db.
    +  private HashMap<String, String> getParamsForQuery() {
    --- End diff --
    
    Ok. 


> OpenTSDB storage plugin
> -----------------------
>
>                 Key: DRILL-5337
>                 URL: https://issues.apache.org/jira/browse/DRILL-5337
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Storage - Other
>            Reporter: Dmitriy Gavrilovych
>            Assignee: Dmitriy Gavrilovych
>              Labels: features
>             Fix For: 1.12.0
>
>
> Storage plugin for OpenTSDB
> The plugin uses REST API to work with TSDB. 
> Expected queries are listed below:
> SELECT * FROM openTSDB.`warp.speed.test`;
> Return all elements from warp.speed.test table with default aggregator SUM
> SELECT * FROM openTSDB.`(metric=warp.speed.test)`;
> Return all elements from (metric=warp.speed.test) table as a previous query, but with
alternative FROM syntax
> SELECT * FROM openTSDB.`(metric=warp.speed.test, aggregator=avg)`;
> Return all elements from warp.speed.test table, but with the custom aggregator
> SELECT `timestamp`, sum(`aggregated value`) FROM openTSDB.`(metric=warp.speed.test, aggregator=avg)`
GROUP BY `timestamp`;
> Return aggregated and grouped value by standard drill functions from warp.speed.test
table, but with the custom aggregator
> SELECT * FROM openTSDB.`(metric=warp.speed.test, downsample=5m-avg)`
> Return data limited by downsample



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message